Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable functional tests #38

Closed
wants to merge 5 commits into from

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Nov 8, 2023

No description provided.

@marchermans
Copy link
Contributor

That is actually on my plan, but I wanted to rewrite them to the new scheme in training wheels.
There is now a builder based approach to this, which should allow making these tests a lot easier.

Do you just want to focus on enabling them, or do you want to also work on porting them to that scheme?

@shartte
Copy link
Contributor Author

shartte commented Nov 9, 2023

Oh no trouble, I can port to that new scheme, I just wasn't sure if it was the future or not, heh

@marchermans
Copy link
Contributor

Oh no trouble, I can port to that new scheme, I just wasn't sure if it was the future or not, heh

They sure as hell are. Hey support more scenarios and have a much simpler handling.

@shartte shartte force-pushed the reactivate-functional-tests branch from 337eb90 to 3d55682 Compare December 2, 2023 18:48
@marchermans
Copy link
Contributor

This has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants