[FIx]: Fix AT issues and mute execute output further #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: aff2c129d0fa2b241637b64cbe7b6447a9a0f59d. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #213' // https://github.com/neoforged/NeoGradle/pull/213
url 'https://prmaven.neoforged.net/NeoGradle/pr213'
content {
includeModule('net.neoforged.gradle', 'platform')
includeModule('net.neoforged.gradle', 'userdev')
includeModule('net.neoforged.gradle', 'dsl-userdev')
includeModule('net.neoforged.gradle', 'dsl-mixin')
includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
includeModule('net.neoforged.gradle', 'neoform')
includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
includeModule('net.neoforged.gradle', 'dsl-platform')
includeModule('net.neoforged.gradle', 'test-utils')
includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
includeModule('net.neoforged.gradle', 'dsl-vanilla')
includeModule('net.neoforged.gradle', 'vanilla')
includeModule('net.neoforged.gradle', 'utils')
includeModule('net.neoforged.gradle', 'mixin')
includeModule('net.neoforged.gradle', 'dsl-neoform')
includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
includeModule('net.neoforged.gradle', 'common')
includeModule('net.neoforged.gradle', 'dsl-common')
}
}
} |
|
Test are failing due to new FML format. Can be ignored. |
sciwhiz12
reviewed
Jun 23, 2024
There was a problem hiding this comment.
I don't see any glaring errors in the logic (and I'm not able to thoroughly test). Just a handful of nitpicks.
Some of the tests should be fixed soon:tm:, particularly those tests which check for SUCCESS but see UP_TO_DATE. There's also some tests which should be looked at soon:tm: that involve the central cache service.
common/src/main/java/net/neoforged/gradle/common/runtime/tasks/SourceAccessTransformer.java
Show resolved
Hide resolved
dsl/common/src/main/groovy/net/neoforged/gradle/dsl/common/util/Constants.groovy
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the JST AT applier would not get the right classpath to analyse the source with.
Now all dependencies of a given runtime are passed in into the JST engine, including the libraries list.