Update AccessTransformer DSL to use new Dependencies DSL to match DependencyHandler #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between when my PR for the AT DSL was opened and when it was merged, DependencyHandler was updated to use gradle's new
DependenciesDSL system, which allows it to support version catalogs natively. This PR enables the same behavior for the AT DSL, which requires usingDependencyCollectorsin it -- due to NG's non-lazy-ification of every single named configuration, this means that the dependency collectors can't actually be added to the configuration untilafterEvaluate, but this is probably fine. Similar to the changes for NG'sDependencyHandler, this should not break buildscripts as the notation is the same, it's just expanded to make use of gradle's full typesafe dependency API.