Add EntityType DeferredRegister

[ChampionAsh5357]

Adds a DeferredRegister subclass for EntityTypes to fix the potential generic inference issues when there are multiple constructors present and the entity factory is constructed within a lambda. This also auto resolves the builder by supplying the ResourceKey in the build method.

The following will now resolve correctly when using the registerType method:

public class ExampleEntity extends Entity {

    public ExampleEntity(EntityType<? extends ExampleEntity> type, Level level) { /*...*/ }

    public ExampleEntity(/*...*/) { /*...*/ }

    // Other methods here
}

public static final DeferredRegister.EntityTypes REGISTRAR = DeferredRegister.createEntityTypes("examplemod");

// Can also be Supplier or Holder
public static final DeferredHolder<EntityType<?>, EntityType<ExampleEntity>> EXAMPLE_ENTITY =
    REGISTRAR.registerType("example_entity", ExampleEntity::new, MobCategory.MISC, builder -> builder);

Technically, var will still throw an exception as it will once again infer that the type of the entity is Entity if there is more than one constructor. This could be fixed by just having the EntityType in the constructor just take in a wildcard rather than be bounded, but that is not best practice, so I will be considering var a non-issue.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: d77dd19f2f82624ef4bb7db5a8cb733434f9b4a0.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.4.59-beta-pr-1854-feat-annoying-entitytype-generics
• 📦 net.neoforged:testframework:21.4.59-beta-pr-1854-feat-annoying-entitytype-generics

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1854' // https://github.com/neoforged/NeoForge/pull/1854
        url 'https://prmaven.neoforged.net/NeoForge/pr1854'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1854.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1854
cd NeoForge-pr1854
curl -L https://prmaven.neoforged.net/NeoForge/pr1854/net/neoforged/neoforge/21.4.59-beta-pr-1854-feat-annoying-entitytype-generics/mdk-pr1854.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[dhyces]

Looks fine. Wonder how many specialized registers we'll end up with 🤔

[Technici4n]

I wonder if it should be called Entities to match DataComponents above.

[Technici4n]

I wonder if it should be called registerEntityType to match registerComponentType above.