Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.1] Fix IClientItemExtensions#renderHelmetOverlay never being called #1836

Merged
merged 4 commits into from
Jan 23, 2025
Merged

[1.21.1] Fix IClientItemExtensions#renderHelmetOverlay never being called #1836

merged 4 commits into from
Jan 23, 2025

Conversation

IThundxr
Copy link
Contributor

@IThundxr IThundxr commented Jan 10, 2025 •
edited
Loading

Backport of #1837

@neoforged-automation neoforged-automation bot added the 1.21.1 Targeted at Minecraft 1.21.1 label Jan 10, 2025
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

dhyces
dhyces previously approved these changes Jan 11, 2025
View reviewed changes
dhyces
dhyces requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@dhyces dhyces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, when a new method is introduced to replace an old method, you call the old method by default within the new if possible. Would prefer that pattern over calling both in sequence.

patches/net/minecraft/client/gui/Gui.java.patch Outdated Show resolved Hide resolved
src/main/java/net/neoforged/neoforge/client/extensions/common/IClientItemExtensions.java Outdated Show resolved Hide resolved
@sciwhiz12 sciwhiz12 added the bug A bug or error label Jan 18, 2025
@IThundxr IThundxr requested a review from dhyces January 19, 2025 15:46
@Matyrobbrt Matyrobbrt merged commit 159fa7f into neoforged:1.21.1 Jan 23, 2025
6 checks passed
@IThundxr IThundxr deleted the pr/fix-renderClientOverlay-1.21.1 branch January 23, 2025 20:27
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matyrobbrt Matyrobbrt Matyrobbrt approved these changes

@dhyces dhyces dhyces approved these changes

Assignees
No one assigned
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IThundxr @dhyces @Matyrobbrt @sciwhiz12