Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax strict Minecraft dependency version requirements for legacy projects #189

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

shartte
Copy link
Collaborator

@shartte shartte commented Dec 2, 2024

Fixes this:

Execution failed for task ':forge:createMinecraftArtifacts'.
> Error while evaluating property 'artifactManifestEntries' of task ':forge:createMinecraftArtifacts'.
   > Could not resolve all artifacts for configuration ':forge:neoFormRuntimeDependenciesRuntimeClasspath'.
      > Could not resolve org.apache.logging.log4j:log4j-api:{strictly 2.17.0}.
        Required by:
            project :forge > net.minecraftforge:forge:1.18.2-40.2.21 > net.neoforged:minecraft-dependencies:1.18.2
> Cannot find a version of 'org.apache.logging.log4j:log4j-api' that satisfies the version constraints:

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 2, 2024

  • Publish PR to GitHub Packages

Last commit published: 189859355b79d81c4b4013e73249a0408365e87f.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #189' // https://github.com/neoforged/ModDevGradle/pull/189
        url 'https://prmaven.neoforged.net/ModDevGradle/pr189'
        content {
            includeModule('net.neoforged.moddev.legacyforge', 'net.neoforged.moddev.legacyforge.gradle.plugin')
            includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
            includeModule('net.neoforged.moddev.repositories', 'net.neoforged.moddev.repositories.gradle.plugin')
            includeModule('net.neoforged', 'moddev-gradle')
        }
    }
}

Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also hardcode the log4j versions, or perhaps only remove the strict version for a few dependencies such as log4j. But this is fine.

@shartte shartte merged commit d897dee into main Dec 2, 2024
6 checks passed
@shartte shartte deleted the relax-version-req-for-legacy branch December 2, 2024 10:01
@neoforged-releases
Copy link

🚀 This PR has been released as ModDevGradle version 2.0.52-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants