-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coc.preferences.formatterExtension
configuration
#5102
Add coc.preferences.formatterExtension
configuration
#5102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5102 +/- ##
==========================================
- Coverage 98.47% 98.41% -0.06%
==========================================
Files 273 273
Lines 26088 26123 +35
Branches 5389 5396 +7
==========================================
+ Hits 25689 25708 +19
- Misses 239 255 +16
Partials 160 160 ☔ View full report in Codecov by Sentry. |
I've tested this and works as expected, thank you for your PR, the |
Please add the update to |
Thank you for your checking! For index.d.ts, is it correct understanding that it is listing public APIs of coc.nvim? Also, should I add some tests for this? The problem is that I'm not familiar with neither JavaScript's testing ecosystem nor coc.nvim's testing utilities. |
OK, let's hide this from the API as the extension name won't be specified, and ignore the tests for now. @statiolake is there any more work to add? |
OK, then I won't update index.d.ts and ignore tests for now. But I think I still need to add this new configuration to history.md. I'll do that later today. |
All done. Please check and merge this if it's OK. |
|
Sorry I didn't notice that. Now fixed. |
9c25f2f fix(typings): getDocument return type. (#5132) d4ff928 feat(language-client): modify log time format (#5130) 53e21a9 fix(snippet): deviation in snippet select in the first column (#5104) 0e6a8c7 feat(codeLens): add codeLens.display (#5129) 704295e fix(handler): correct current winid (#5128) aabfc23 fix: ignore failed config file reads (#5118) 56ea360 feat: expose more properties quick list (#5114) 37f98a1 feat(util): adjust to vim's Patch 9.1.327 (#5122) 80e9f1b chore(package): upgrade micromatch (#5127) 98fa66a chore(packages): lock ESLint versions for now (#5108) bf3d1f6 Add `coc.preferences.formatterExtension` configuration (#5102) 38697bc chore(handle): typo toggle inlayHint (#5105)
This is a proof-of-concept.
coc-pyright
): identified by extension name as expected@yaegassy/coc-ruff
): identified by extension name as expectedlanguageserver
configuration: identified ascoc.nvim
Priorities are still expected to work (when
coc.preferences.formatterExtension
is null).Closes #5076