fixed invalid bookmark spec

neo4jrb · May 3, 2024 · a577e67 · a577e67
1 parent 1e0117e
commit a577e67
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/.github/workflows/specs.yml b/.github/workflows/specs.yml
@@ -17,39 +17,32 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [  jruby-9.3.14.0, jruby, ruby-3.1.5, ruby ]
+        ruby: [  jruby, ruby-3.1.5, ruby ]
         neo4j: [ 3.5.35, 4.0.12, 4.1.12, 4.2.19, 4.3.23, 4.4.33, 5.19.0 ]
+        active_support: [ '' ]
         include:
           - neo4j: 3.5.35
             java-version: 8
           - neo4j: 5.19.0
             java-version: 17
             options: "-t ~causal"
 
-          - neo4j: 5.7.0
-            ruby: ruby-3.1.5
-            java-version: 17
-            options: "-t ~causal"
-          - neo4j: 5.8.0
-            ruby: ruby-3.1.5
-            java-version: 17
-            options: "-t ~causal"
-          - neo4j: 5.7.0
+          - neo4j: 5.19.0
             ruby: ruby-3.1.5
             java-version: 17
             options: "-t ~causal"
             active_support:  7.0.8.1
-          - neo4j: 5.7.0
+          - neo4j: 5.19.0
             ruby: ruby-3.1.5
             java-version: 17
             options: "-t ~causal"
             active_support: 6.1.7.7
-          - neo4j: 5.7.0
+          - neo4j: 5.19.0
             ruby: ruby-3.1.5
             java-version: 17
             options: "-t ~causal"
             active_support: 6.0.6.1
-          - neo4j: 5.7.0
+          - neo4j: 5.19.0
             ruby: ruby-3.1.5
             java-version: 17
             options: "-t ~causal"

diff --git a/spec/integration/bookmark_spec.rb b/spec/integration/bookmark_spec.rb
@@ -33,8 +33,8 @@ def expect_single_value(bookmark, value)
   end
 
   # TODO: The version restriction should not be present here!
-  it 'raises for invalid bookmark', version: '<=5.7.0' do
-    invalid_bookmark = Neo4j::Driver::Bookmark.from(Set['hi, this is an invalid bookmark'])
+  it 'raises for invalid bookmark' do
+    invalid_bookmark = Neo4j::Driver::Bookmark.from('hi, this is an invalid bookmark')
     expect { driver.session(bookmarks: invalid_bookmark, &:begin_transaction) }
       .to raise_error Neo4j::Driver::Exceptions::ClientException
   end