Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Vulcan-224/Execute button and hide query editor for non auto run reports #646

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

m-o-n-i-s-h
Copy link
Contributor

Currently, NeoDash fires queries as soon as all input parameters are given. And there is one setting in report "Auto run", But my user wants to execute the cypher query after changing all the parameters. Also my user don't want to display the cypher query to the other users.

So, We have added one more property in the settings "hideQueryEditorInAutoRunOnMode". By enabling this, User will be able to see one execute button whenever there is a change in the parameter.

execute button optimize

NOTICE
The program was tested solely for our own use cases, which might differ from yours.
Author Info: Monish [email protected] on behalf of Mercedes-Benz Research and Development India
https://github.com/mercedes-benz/mercedes-benz-foss/blob/master/PROVIDER_INFORMATION.md

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
9.8% 9.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: Patch coverage is 68.75000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 46.39%. Comparing base (19b7538) to head (1b136b4).
Report is 45 commits behind head on develop.

❗ Current head 1b136b4 differs from pull request most recent head c72981d. Consider uploading reports for the commit c72981d to get more accurate results

Files Patch % Lines
src/card/view/CardView.tsx 44.44% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #646      +/-   ##
===========================================
+ Coverage    37.49%   46.39%   +8.90%     
===========================================
  Files          216      167      -49     
  Lines         9140     6619    -2521     
  Branches      2703     2046     -657     
===========================================
- Hits          3427     3071     -356     
+ Misses        5654     3507    -2147     
+ Partials        59       41      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant