Contract invoke should check to ensure either account or --results is…

… specified (#145) Fixes #144 Co-authored-by: Harry <[email protected]>
neo-project · Jun 15, 2021 · ed990c1 · ed990c1
1 parent 5333fd1
commit ed990c1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/neoxp/Commands/ContractCommand.Invoke.cs b/src/neoxp/Commands/ContractCommand.Invoke.cs
@@ -53,6 +53,11 @@ internal async Task<int> OnExecuteAsync(IConsole console)
             {
                 try
                 {
+                    if (string.IsNullOrEmpty(Account) && !Results)
+                    {
+                        throw new Exception("Either Account or --results must be specified");
+                    }
+
                     var (chainManager, _) = chainManagerFactory.LoadChain(Input);
 
                     if (Results)
@@ -80,7 +85,6 @@ internal async Task<int> OnExecuteAsync(IConsole console)
                     return 1;
                 }
             }
-
         }
     }
 }
diff --git a/src/neoxp/Extensions/ExpressChainExtensions.cs b/src/neoxp/Extensions/ExpressChainExtensions.cs
@@ -51,6 +51,8 @@ public static bool IsReservedName(this ExpressChain chain, string name)
 
         public static string ResolvePassword(this ExpressChain chain, string name, string password)
         {
+            if (string.IsNullOrEmpty(name)) throw new ArgumentException($"{nameof(name)} parameter can't be null or empty", nameof(name));
+
             // if the user specified a password, use it
             if (!string.IsNullOrEmpty(password)) return password;