Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return an error when the argument count is wrong #2510

Closed
wants to merge 1 commit into from

Conversation

earl-warren
Copy link

No description provided.

@earl-warren earl-warren requested a review from a team as a code owner November 1, 2024 06:32
@ChristopherHX
Copy link
Contributor

ChristopherHX commented Nov 1, 2024

@earl-warren Is this coming from a fork of act? like forgeo~~/gitea~~ those lack behind updates

The act/schema package aborts already in this case as of August 2024.

@ChristopherHX
Copy link
Contributor

FYI

err = errors.Join(err, fmt.Errorf("Missing parameters for %s expected >= %v got %v", funcCallNode.Callee, v.min, len(funcCallNode.Args)))

@ChristopherHX
Copy link
Contributor

What is codespell doing???

Error: ./pkg/exprparser/interpreter.go:599: atLeast ==> at least

Why does this tool think there must be a space in a variable

Copy link
Contributor

mergify bot commented Nov 1, 2024

@earl-warren this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.04%. Comparing base (5a80a04) to head (bd7d66e).
Report is 127 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2510       +/-   ##
===========================================
+ Coverage   61.56%   75.04%   +13.48%     
===========================================
  Files          53       62        +9     
  Lines        9002    10044     +1042     
===========================================
+ Hits         5542     7538     +1996     
+ Misses       3020     1939     -1081     
- Partials      440      567      +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the needs-work Extra attention is needed label Nov 1, 2024
@earl-warren
Copy link
Author

@earl-warren Is this coming from a fork of act? like forgeo~~/gitea~~ those lack behind updates

The act/schema package aborts already in this case as of August 2024.

Yes, sorry about that.

@earl-warren earl-warren closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants