-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for listartifacts v4 filter #2507
Conversation
* fixes a defect of last change
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2507 +/- ##
===========================================
+ Coverage 61.56% 75.01% +13.44%
===========================================
Files 53 62 +9
Lines 9002 10013 +1011
===========================================
+ Hits 5542 7511 +1969
+ Misses 3020 1936 -1084
- Partials 440 566 +126 ☔ View full report in Codecov by Sentry. |
@wolfogre my last artifacts change got merged too fast. I'm good in programming bugs :). After reviewing my own code I had to fix problems, writing code on a phone has side effects. Now this is covered by tests and ci logs looks good |
I reviewed my own code today and saw
||
instead of&&
resulting in broken artifact matching.After fixing this I noticed that nodejs truncates the int64 ids so switch to 32bit that fitd in double.
Additionally added an actual test what this change should fix