Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for listartifacts v4 filter #2507

Merged
merged 4 commits into from
Oct 29, 2024
Merged

add test for listartifacts v4 filter #2507

merged 4 commits into from
Oct 29, 2024

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Oct 28, 2024

  • fixes a defect of last change

I reviewed my own code today and saw || instead of && resulting in broken artifact matching.

After fixing this I noticed that nodejs truncates the int64 ids so switch to 32bit that fitd in double.

Additionally added an actual test what this change should fix

* fixes a defect of last change
Copy link
Contributor

github-actions bot commented Oct 28, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.43s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.82s
✅ REPOSITORY secretlint yes no 1.21s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 3.43s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (5a80a04) to head (d07f371).
Report is 126 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2507       +/-   ##
===========================================
+ Coverage   61.56%   75.01%   +13.44%     
===========================================
  Files          53       62        +9     
  Lines        9002    10013     +1011     
===========================================
+ Hits         5542     7511     +1969     
+ Misses       3020     1936     -1084     
- Partials      440      566      +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX ChristopherHX marked this pull request as ready for review October 28, 2024 19:01
@ChristopherHX ChristopherHX requested a review from a team as a code owner October 28, 2024 19:01
@ChristopherHX
Copy link
Contributor Author

@wolfogre my last artifacts change got merged too fast. I'm good in programming bugs :). After reviewing my own code I had to fix problems, writing code on a phone has side effects.

Now this is covered by tests and ci logs looks good

@mergify mergify bot merged commit e3b4e3a into master Oct 29, 2024
12 checks passed
@mergify mergify bot deleted the fix-v4-defect branch October 29, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants