Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge-multiple artifacts were broken #2505

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Oct 27, 2024

Fixes #2433

I replaced the hardcoded id by a hash code of the name, if you have a better idea let me know.

We don't have a database with actual id's and this seems to be the most trivial fix

Copy link
Contributor

github-actions bot commented Oct 27, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.36s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.06s
✅ REPOSITORY secretlint yes no 1.08s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 3.25s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ChristopherHX ChristopherHX marked this pull request as ready for review October 27, 2024 16:20
@ChristopherHX ChristopherHX requested a review from a team as a code owner October 27, 2024 16:20
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.03%. Comparing base (5a80a04) to head (f82bc1c).
Report is 124 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2505       +/-   ##
===========================================
+ Coverage   61.56%   75.03%   +13.46%     
===========================================
  Files          53       62        +9     
  Lines        9002    10013     +1011     
===========================================
+ Hits         5542     7513     +1971     
+ Misses       3020     1937     -1083     
- Partials      440      563      +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit f77a443 into master Oct 28, 2024
12 checks passed
@mergify mergify bot deleted the ChristopherHX-patch-1 branch October 28, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actions/download-artifact@v4 downloads wrong file
2 participants