-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: artifact v4 upload above 8MB #2402
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2402 +/- ##
===========================================
+ Coverage 61.56% 76.62% +15.06%
===========================================
Files 53 62 +9
Lines 9002 8164 -838
===========================================
+ Hits 5542 6256 +714
+ Misses 3020 1343 -1677
- Partials 440 565 +125 ☔ View full report in Codecov by Sentry. |
gitea still has problems in this case, but it could be act doesn't have shown this issue because of less database acceses Investigating using the blocklist at least for gitea |
I don't have any plans for further improvements like done for Gitea in act. |
Multiple chunks are uploaded with type "block" without using "appendBlock", my .net Implementation didn't have different handling for these upload type and this solves the issue for act itself
8MB seems to be the chunk size
Closes #2351
Closes #2371