Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker stub and add a test for this #2355

Merged
merged 4 commits into from
Jul 10, 2024
Merged

fix: docker stub and add a test for this #2355

merged 4 commits into from
Jul 10, 2024

Conversation

ChristopherHX
Copy link
Contributor

Build tag without WITHOUT_DOCKER were not covered by CI

Next steps are refactoring coverage collection that all go run and go test results are merged

@ChristopherHX ChristopherHX requested a review from a team as a code owner June 6, 2024 15:43
Copy link
Contributor

github-actions bot commented Jun 6, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.34s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 8.6s
✅ REPOSITORY secretlint yes no 1.22s
✅ REPOSITORY trivy-sbom yes no 0.5s
✅ REPOSITORY trufflehog yes no 4.87s
✅ YAML prettier 1 0 0.33s
✅ YAML v8r 1 0 1.99s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.59%. Comparing base (5a80a04) to head (9deb39c).
Report is 90 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2355       +/-   ##
===========================================
+ Coverage   61.56%   76.59%   +15.03%     
===========================================
  Files          53       61        +8     
  Lines        9002     7893     -1109     
===========================================
+ Hits         5542     6046      +504     
+ Misses       3020     1292     -1728     
- Partials      440      555      +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -46,8 +46,8 @@ func RunnerArch(ctx context.Context) string {
return runtime.GOOS
}

func GetHostInfo(ctx context.Context) (info types.Info, err error) {
return types.Info{}, nil
func GetHostInfo(ctx context.Context) (info system.Info, err error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably a docker api update, that affected undetected files

@@ -60,6 +60,8 @@ jobs:
upload-logs-name: logs-linux
- name: Run act from cli
run: go run main.go -P ubuntu-latest=node:16-buster-slim -C ./pkg/runner/testdata/ -W ./basic/push.yml
- name: Run act from cli without docker support
run: go run -tags WITHOUT_DOCKER main.go -P ubuntu-latest=-self-hosted -C ./pkg/runner/testdata/ -W ./local-action-js/push.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm building act as dependency of platforms using docker_stub, so noticed it stopped compiling after merging

Copy link
Contributor

mergify bot commented Jul 10, 2024

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jul 10, 2024
@mergify mergify bot removed the needs-work Extra attention is needed label Jul 10, 2024
@mergify mergify bot merged commit 3c7eda7 into master Jul 10, 2024
11 checks passed
@mergify mergify bot deleted the fix-docker-stub branch July 10, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants