-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docker stub and add a test for this #2355
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2355 +/- ##
===========================================
+ Coverage 61.56% 76.59% +15.03%
===========================================
Files 53 61 +8
Lines 9002 7893 -1109
===========================================
+ Hits 5542 6046 +504
+ Misses 3020 1292 -1728
- Partials 440 555 +115 ☔ View full report in Codecov by Sentry. |
@@ -46,8 +46,8 @@ func RunnerArch(ctx context.Context) string { | |||
return runtime.GOOS | |||
} | |||
|
|||
func GetHostInfo(ctx context.Context) (info types.Info, err error) { | |||
return types.Info{}, nil | |||
func GetHostInfo(ctx context.Context) (info system.Info, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably a docker api update, that affected undetected files
@@ -60,6 +60,8 @@ jobs: | |||
upload-logs-name: logs-linux | |||
- name: Run act from cli | |||
run: go run main.go -P ubuntu-latest=node:16-buster-slim -C ./pkg/runner/testdata/ -W ./basic/push.yml | |||
- name: Run act from cli without docker support | |||
run: go run -tags WITHOUT_DOCKER main.go -P ubuntu-latest=-self-hosted -C ./pkg/runner/testdata/ -W ./local-action-js/push.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm building act as dependency of platforms using docker_stub, so noticed it stopped compiling after merging
@ChristopherHX this pull request has failed checks 🛠 |
Build tag without WITHOUT_DOCKER were not covered by CI
Next steps are refactoring coverage collection that all go run and go test results are merged