Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Pkg Coverage #2293

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Cross Pkg Coverage #2293

merged 2 commits into from
Apr 12, 2024

Conversation

ChristopherHX
Copy link
Contributor

We have many integration tests, which doesn't count as coverage as of Today

Copy link
Contributor

github-actions bot commented Apr 11, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.0s
✅ REPOSITORY gitleaks yes no 2.29s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 7.61s
✅ REPOSITORY secretlint yes no 1.0s
✅ REPOSITORY trivy-sbom yes no 0.6s
✅ REPOSITORY trufflehog yes no 6.41s
✅ YAML prettier 1 0 0.23s
✅ YAML v8r 1 0 1.69s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.52%. Comparing base (5a80a04) to head (ccede94).
Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2293       +/-   ##
===========================================
+ Coverage   61.56%   76.52%   +14.96%     
===========================================
  Files          53       59        +6     
  Lines        9002     7506     -1496     
===========================================
+ Hits         5542     5744      +202     
+ Misses       3020     1240     -1780     
- Partials      440      522       +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherHX
Copy link
Contributor Author

The result is +14.93% of collected coverage data

@ChristopherHX ChristopherHX marked this pull request as ready for review April 11, 2024 20:56
@ChristopherHX ChristopherHX requested a review from a team as a code owner April 11, 2024 20:56
@ChristopherHX
Copy link
Contributor Author

This is documented here https://go.dev/doc/build-cover

@mergify mergify bot merged commit 8cdc3fc into master Apr 12, 2024
10 checks passed
@mergify mergify bot deleted the cross-pkg-coverage branch April 12, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants