-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: filecollector into new package #2174
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2174 +/- ##
==========================================
+ Coverage 60.97% 61.56% +0.58%
==========================================
Files 53 53
Lines 9002 9002
==========================================
+ Hits 5489 5542 +53
+ Misses 3074 3020 -54
- Partials 439 440 +1 ☔ View full report in Codecov by Sentry. |
@ChristopherHX this pull request has failed checks 🛠 |
After updating the codecov base via workflow_dispatch, this PR has been flagged until I added tests to increase diff coverage of existing code |
* refactor: filecollector into new package * Add test for symlinks * add test fix bug of GetContainerArchive * add test data
To be able to reuse this logic across packages it makes sense for me to export it and move this into a new package.
This helps to remove the copy of filecollector in #2155