Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: filecollector into new package #2174

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

ChristopherHX
Copy link
Contributor

To be able to reuse this logic across packages it makes sense for me to export it and move this into a new package.

This helps to remove the copy of filecollector in #2155

@ChristopherHX ChristopherHX requested a review from a team as a code owner January 28, 2024 20:15
Copy link
Contributor

github-actions bot commented Jan 28, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 5 0 0.02s
✅ REPOSITORY gitleaks yes no 2.3s
✅ REPOSITORY git_diff yes no 0.17s
✅ REPOSITORY grype yes no 7.39s
✅ REPOSITORY secretlint yes no 1.21s
✅ REPOSITORY trivy-sbom yes no 0.63s
✅ REPOSITORY trufflehog yes no 7.24s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (4ca35d2) 60.97% compared to head (43b091b) 61.56%.

Files Patch % Lines
pkg/filecollector/file_collector.go 25.00% 6 Missing ⚠️
pkg/container/docker_run.go 0.00% 4 Missing ⚠️
pkg/container/host_environment.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2174      +/-   ##
==========================================
+ Coverage   60.97%   61.56%   +0.58%     
==========================================
  Files          53       53              
  Lines        9002     9002              
==========================================
+ Hits         5489     5542      +53     
+ Misses       3074     3020      -54     
- Partials      439      440       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Jan 29, 2024

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jan 29, 2024
@ChristopherHX ChristopherHX marked this pull request as draft January 29, 2024 14:45
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 29, 2024
@mergify mergify bot removed the needs-work Extra attention is needed label Jan 29, 2024
@ChristopherHX ChristopherHX marked this pull request as ready for review January 29, 2024 17:43
@ChristopherHX
Copy link
Contributor Author

After updating the codecov base via workflow_dispatch, this PR has been flagged until I added tests to increase diff coverage of existing code

@mergify mergify bot merged commit 5a80a04 into master Jan 30, 2024
10 checks passed
@mergify mergify bot deleted the refactor-filecollector-into-new-package branch January 30, 2024 00:46
jmikedupont2 pushed a commit to meta-introspector/act that referenced this pull request Mar 10, 2024
* refactor: filecollector into new package

* Add test for symlinks

* add test fix bug of GetContainerArchive

* add test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants