Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite #13

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Improve test suite #13

wants to merge 17 commits into from

Conversation

hulkoba
Copy link

@hulkoba hulkoba commented Jul 1, 2024

Hello 👋!

As part of the STF work for Conda, this PR introduces several improvements to our testing framework by transitioning from unittest to pytest, leveraging pytest-mock for mocking, and adopting snapshot testing with syrupy.

Note that the testing section in the readme is updated at conda-forge/conda-smithy/pull/1956

Thank you!

Checklist

  • Added a news entry

@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 2, 2024
@hulkoba hulkoba force-pushed the add_snapshots branch 3 times, most recently from 5415f50 to cf883dd Compare July 2, 2024 11:52
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@hulkoba hulkoba force-pushed the add_snapshots branch 3 times, most recently from efd7fab to 8242966 Compare July 3, 2024 08:49
@hulkoba hulkoba marked this pull request as ready for review July 3, 2024 08:50
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@hulkoba hulkoba changed the title Add snapshots Modernize test suite Jul 3, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@@ -9,10 +9,12 @@ dependencies:
- python-build
- setuptools>=45
- setuptools_scm>=8.1
- syrupy
- tomli>=1.0.0
- pre-commit
- mock
Copy link
Author

@hulkoba hulkoba Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mock is not needed anymore

@neighbourhoodie neighbourhoodie deleted a comment from coveralls Jul 3, 2024
@coveralls
Copy link

coveralls commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9904939804

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.162%

Totals Coverage Status
Change from base Build 9904091487: 0.0%
Covered Lines: 2835
Relevant Lines: 4081

💛 - Coveralls

@hulkoba hulkoba changed the title Modernize test suite Improve test suite Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants