Change title data regex to accommodate new HBO player and improve ana…

…lytics
nehalvpatel · Oct 11, 2016 · 6a90a3b · 6a90a3b
1 parent 51e9c93
commit 6a90a3b
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 11 deletions.
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1 @@
+.vscode/.*
diff --git a/manifest.json b/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "HBO Now • Force Resolution",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "manifest_version": 2,
   "description": "Allows you to force 1080p HD video on HBONow.com.",
   "icons": {

diff --git a/src/bg/background.js b/src/bg/background.js
@@ -96,13 +96,14 @@ function handleRequest(details) {
                 let allowedResolution = allTabs[details.tabId]["allowedStreams"][details.url];
                 logData(details.tabId, "Allowed " + allowedResolution + "p.");
 
-                chrome.tabs.sendMessage(details.tabId, { "event": "getTitle", "resolution": allowedResolution }, function(content) {
-                    ga("send", "event", {
-                        "eventCategory": "Video",
-                        "eventAction": "Play",
-                        "eventLabel": content["videoTitle"],
-                        "eventValue": allowedResolution
-                    });
+                chrome.tabs.sendMessage(details.tabId, { "event": "getTitle" }, function(content) {
+                    ga("send", "event", "Video", "Play",
+                        {
+                            "dimension1": content["videoTitle"],
+                            "dimension2": desiredResolution + "p",
+                            "dimension3": allowedResolution + "p"
+                        }
+                    );
                 });
             }
         }

diff --git a/src/inject/inject.js b/src/inject/inject.js
@@ -12,7 +12,7 @@ chrome.runtime.onMessage.addListener(function (msg, sender, sendResponse) {
 
         let dataBootstrap = {};
         let dataBootstrapRegex;
-        if ((dataBootstrapRegex = document.documentElement.innerHTML.match(/dataBootstrap = (.*),/)) !== null) {
+        if ((dataBootstrapRegex = document.documentElement.innerHTML.match(/dataBootstrap = (.*)[;|,]/)) !== null) {
             dataBootstrap = JSON.parse(dataBootstrapRegex[1]);
         }
 

diff --git a/src/page_action/page_action.js b/src/page_action/page_action.js
@@ -23,9 +23,9 @@ window.onload = function () {
             document.getElementById("nearest").innerText = this.value + "p";
 
             ga("send", "event", {
-                "eventCategory": "Resolution",
+                "eventCategory": "DesiredResolution",
                 "eventAction": "Change",
-                "eventValue": parseInt(this.value)
+                "eventLabel": this.value + "p"
             });
         }
     }