chore(ci): make tests run on windows as well #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good, thanks for the change and the upstream fix. Let's keep this on hold until the upstream dependency releases a new version then. |
…and windows builds
|
The new version of postgrator-cli was published and I've separated the windows build into its own job to avoid mixing up linux and windows containers since that's not supported in Github Actions. Everything seems to be working fine now. |
simoneb
reviewed
Jan 16, 2025
simoneb
approved these changes
Jan 16, 2025
|
good to go, feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 734
Currently the CI build will fail at the
db:migratestep on Windows due to MattiLehtinen/postgrator-cli#261, however I have also ran the CI build against my own branch https://github.com/Pupix/postgrator-cli/tree/fix/windows-relative-path and everything works as expected.Will have to wait for them to merge and release a new minor version to properly test it.