Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump borsh to v1.0.0 and remove the better-sqlite3 #1231

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kujtimprenku
Copy link
Contributor

@kujtimprenku kujtimprenku commented Nov 3, 2024

Description

  • Bump borsh to v1.0.0 it's been more than 1y since v1.0.0 was published and used by NAJ.
  • Update code where borsh is used directly
  • Remove better-sqlite3

The better-sqlite3 requires C++ Developer Tools to be installed in a Windows OS. Since this dependency is not used anywhere in any of the packages it can be removed.

Windows users can now install dependencies without this error:
node-gyp-sqlite

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@kujtimprenku kujtimprenku changed the base branch from main to dev November 3, 2024 13:11
@github-actions github-actions bot changed the title Bump borsh to v1.0.0 and remove the better-sqlite3 feat: Bump borsh to v1.0.0 and remove the better-sqlite3 Nov 3, 2024
@Emadalshamery Emadalshamery mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants