-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updates near-* dependencies to 0.27 release #1254
Conversation
@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! @dj8yfo received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
+ Coverage 80.09% 80.33% +0.24%
==========================================
Files 102 102
Lines 14597 14598 +1
==========================================
+ Hits 11691 11728 +37
+ Misses 2906 2870 -36 ☔ View full report in Codecov by Sentry. |
this looks like a spot where a self-referential struct is moved https://github.com/near/near-sdk-rs/blob/master/near-sdk/src/environment/env.rs?plain=1#L102 |
@race-of-sloths score 5 |
I am not sure that I understand what you imply by that :( |
@dj8yfo do you have ability to update required jobs ? |
@akorchyn looks like some glitch, as first commit probably didn't have workflows update. I'll try rerunning Test core job, but you must have perm to rerun too. |
It's not a glitch actually. You specify required job names in repo settings. But as rust toolchain is part of the name, that's why it doesn't match. I don't have enough rights @frol can you update job config |
Or maybe even closing, adding some whitespace change (so that's its a new commit, unknown to gh), and opening a new pr from another branch. I don't know, why gh wants to make everything so painful, but this pr https://github.com/near/near-sdk-rs/pull/1231/files seemingly had a similar change and i don't remember anyone having to edit repo config to merge it. |
I tried squash and open new PR here: #1258 Seems to be like it doesn't work that way :( |
@race-of-sloths