Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates near-* dependencies to 0.27 release #1254

Merged
merged 5 commits into from
Nov 14, 2024
Merged

chore: updates near-* dependencies to 0.27 release #1254

merged 5 commits into from
Nov 14, 2024

Conversation

akorchyn
Copy link
Collaborator

@akorchyn akorchyn changed the title chore!: updates near-* dependencies to 0.27 release chore: updates near-* dependencies to 0.27 release Nov 12, 2024
@race-of-sloths
Copy link

race-of-sloths commented Nov 12, 2024

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@dj8yfo 5

Your contribution is much appreciated with a final score of 5!
You have received 53 (50 base + 5% lifetime bonus) Sloth points for this contribution

@dj8yfo received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.33%. Comparing base (eda17d5) to head (c303874).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
+ Coverage   80.09%   80.33%   +0.24%     
==========================================
  Files         102      102              
  Lines       14597    14598       +1     
==========================================
+ Hits        11691    11728      +37     
+ Misses       2906     2870      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 13, 2024

this looks like a spot where a self-referential struct is moved https://github.com/near/near-sdk-rs/blob/master/near-sdk/src/environment/env.rs?plain=1#L102

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 13, 2024

checked that this doesn't block #1253 in any way with #1255

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 13, 2024

@race-of-sloths score 5

@dj8yfo dj8yfo self-requested a review November 13, 2024 15:53
dj8yfo
dj8yfo previously approved these changes Nov 13, 2024
@akorchyn akorchyn requested a review from dj8yfo November 13, 2024 16:06
@akorchyn
Copy link
Collaborator Author

This looks like a spot where a self-referential struct is moved https://github.com/near/near-sdk-rs/blob/master/near-sdk/src/environment/env.rs?plain=1#L102

I am not sure that I understand what you imply by that :(

@akorchyn
Copy link
Collaborator Author

@dj8yfo do you have ability to update required jobs ?

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 13, 2024

@akorchyn looks like some glitch, as first commit probably didn't have workflows update. I'll try rerunning Test core job, but you must have perm to rerun too.

@akorchyn
Copy link
Collaborator Author

It's not a glitch actually. You specify required job names in repo settings. But as rust toolchain is part of the name, that's why it doesn't match. I don't have enough rights

@frol can you update job config

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 13, 2024

@akorchyn cancel the running jobs, then try closing/reopening the pr.
In #1253 the first pushed commit changed the workflows and they were picked up correctly, not requiring stuff from pr's base branch

@akorchyn akorchyn closed this Nov 13, 2024
@akorchyn akorchyn reopened this Nov 13, 2024
@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 13, 2024

Or maybe even closing, adding some whitespace change (so that's its a new commit, unknown to gh), and opening a new pr from another branch. I don't know, why gh wants to make everything so painful, but this pr https://github.com/near/near-sdk-rs/pull/1231/files seemingly had a similar change and i don't remember anyone having to edit repo config to merge it.
Or squashing pr into single commit and reopening from new branch...

@akorchyn
Copy link
Collaborator Author

I tried squash and open new PR here: #1258

Seems to be like it doesn't work that way :(

@frol frol merged commit 110a99a into master Nov 14, 2024
54 of 62 checks passed
@frol frol deleted the 0.27 branch November 14, 2024 14:14
@frol frol mentioned this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants