-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check for supported near-sdk version #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you can remove #[ignore]
from cargo::test_dependency_platform_specific
. Seems like cargo metadata
is choosing the right dependency depending on the target which is a cool side effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, the changes look good to me even as is. Going to approve to unblock.
Co-authored-by: Daniyar Itegulov <[email protected]>
Fixes #29
Reduced the scope of errors from dep checking to 3.
unable to appropriately resolve the dependency graph, perhaps your `Cargo.toml` file is malformed
`near-sdk` dependency not found
unsupported `near-sdk` version. expected 4.1.* or higher
Hopefully they're descriptive enough.
Adapted the integration tests from #48.