-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal to restrict ethereum address on NEAR #492
Conversation
Your Render PR Server URL is https://nomicon-pr-492.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cj1eubr438is380ja8n0. |
db338c1
to
bcbc6dc
Compare
What restrictions are there on creating an address through the registrar account? Will it require a signature with the Ethereum private key to prevent spam? |
Seems hacky. Why not restrict creation of top-level accounts entirely? Is there a use case for user-created top-level accounts (other than implicit accounts)? Making a wallet that automatically switches between NEAR and Ethereum based on address doesn't sound good, because this approach cannot be extended to support other chains (many of which use the same address format as Ethereum). Similarly, this proposal may prevent users from accidentally withdrawing their tokens to NEAR, but not to any of the other chains, so this solution doesn't scale. By the way, do exchanges even prevent withdrawals to a non-existent address? In most blockchains, transferring tokens to a non-existent address is not a problem, so many exchanges may not have any code to detect that. A much better approach would be to standardize a set of prefixes denoting the chain, e.g. prepend |
This seems to be a problem to be solved in the wallet / web interface, rather than in the protocol. Agree with @abacabadabacaba that this proposal feels hacky. What if someone pastes an ethereum address without |
neps/nep-0492.md
Outdated
### Backwards Compatibility | ||
|
||
There is no backwards compatibility concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To some extent there is given there are ~5k such addresses already.
Thank you @bowenwang1996 for submitting this NEP. As a moderator, I reviewed this NEP and it meets the proposed template guidelines. I am moving this NEP to the REVIEW stage and would like to ask the @near/wg-protocol working group members to assign 2 Technical Reviewers to complete a technical review (see expectations below). Just for clarity, Technical Reviewers play a crucial role in scaling NEAR ecosystem as they provide their in-depth expertise in the niche topic while work group members can stay on guard of the NEAR ecosystem. The discussions may get too deep and it would be inefficient for each WG member to dive into every single comment, so NEAR Developer Governance designed this process that includes subject matter experts helping us to scale by writing a summary with the raised concerns and how they were addressed. Technical Review Guidelines
Technical Summary guidelines:
Here is a nice example and a template for your convenience:
Please tag the @near/nep-moderators once you are done, so we can move this NEP to the voting stage. Thanks again. |
yeah I think restricting all TLDs (other than implicit accounts) make sense. |
@abacabadabacaba @mfornet the proposal is updated to restrict the creation of all top level accounts (other than implicit accounts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me as a way to prevent scams. Might be worth doing a little more research though to see if there are other top-level accounts which currently exist and would have been prevented by this proposal.
|
||
In addition to prevent loss of funds for users, this change allows the possibility of Ethereum wallets supporting NEAR transactions, which could enable much more adoption of NEAR. The exact details of how that would be done is outside the scope of this proposal. | ||
|
||
There are currently ~5000 Ethereum addresses already created on NEAR. It is also outside the scope of this proposal to discuss what to do with them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other non-Ethereum-like top level accounts whos creation would have been restricted by this proposal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a total of 11423 accounts on mainnet that are top-level accounts longer than 32 characters and that are not implicit accounts. I don't think there is a clear pattern that people use top-level accounts longer than 32 characters for.
@frol given that both Marcelo and Michael have approved the proposal, looks like we have a majority of support from the protocol working group. What else do we need to merge this proposal? |
@bowenwang1996 Thank you for reaching out! I moved this NEP to final comment period and will ask @near/nep-moderators to schedule a Protocol WG call to present this NEP to community and formally vote on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a member of the protocol working group, I approve this NEP.
Some notes from the discussion we had at the last open working group meeting:
- The title should be changed to reflect the increased scope (all top level accounts disallowed, not just Ethereum-like)
- Concerns around censorship should be addressed in follow-up discussions (i.e. actually spec out the top-level account name auction system; and in the meantime make the current registrar account more permissive).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a member of the Protocol WG I approve this NEP
Thank you to everyone who attended the fifth Protocol Work Group call yesterday! The work group members reviewed the NEP and reached the following consensus: Status: Approved
Meeting Recording: @bowenwang1996 Thank you for authoring this NEP! Next Steps:
|
Stabilize near/NEPs#492. Restrict the creation of non-implicit top-level account that are longer than 32 bytes. Only the registrar account can create them. More context on the proposal: - The NEP has been officially approved in September (near/NEPs#492 (comment)). - #9589 implements the feature and includes tests checking that TLA can no longer be created in the new protocol version.
Stabilize near/NEPs#492. Restrict the creation of non-implicit top-level account that are longer than 32 bytes. Only the registrar account can create them. More context on the proposal: - The NEP has been officially approved in September (near/NEPs#492 (comment)). - #9589 implements the feature and includes tests checking that TLA can no longer be created in the new protocol version.
Proposal to restrict the creation of Ethereum addresses on NEAR to prevent loss of funds and enable future possibilities for Ethereum wallets to support NEAR transactions.
Implementation: near/nearcore#9365