Don't thow an error when string can't be decoded to ascii #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed import
Don't yield anything on error, just pass.
ndokter
requested changes
Jan 28, 2025
dsmr_parser/clients/serial_.py
Outdated
| try: | ||
| decoded_data = data.decode('ascii') | ||
| except: | ||
| pass |
There was a problem hiding this comment.
Maybe put a logger statement here:
logger.warning('Failed to decode telegram data: %s', e)
dsmr_parser/clients/serial_.py
Outdated
| try: | ||
| decoded_data = data.decode('ascii') | ||
| except: | ||
| pass |
There was a problem hiding this comment.
Maybe put a logger statement here:
logger.warning('Failed to decode telegram data: %s', e)
dsmr_parser/clients/serial_.py
Outdated
| try: | ||
| decoded_data = data.decode('ascii') | ||
| except: | ||
| pass |
There was a problem hiding this comment.
Maybe put a logger statement here:
logger.warning('Failed to decode telegram data: %s', e)
|
Makes sense, tough I'd consider outputting |
|
Alright the python 3.7 doesnt seem to run, but your change looks good. Thanks! I will try to make a new build soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for Issue #80. Instead of throwing an exception when input from serial can't be parsed, it passes the current step while the loop keeps going. This will mean one 'row' is missing from the telegram. The user should keep this in mind and not expect every telegram to be formed the same way.
Another option is to yield None, which I tried first. On second thought, it is not that helpful because there is nothing to return (though we could give the 'raw' bytestring, but that would complicate things for the user as well.