Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PoPS Core with explicit casts #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenzeslaus
Copy link
Member

This updates PoPS Core code to the latest version on main with explicit casts and conversions from floating point numbers to integers and booleans.

This updates PoPS Core code to the latest version on main with explicit casts and conversions from floating point numbers to integers and booleans.
@wenzeslaus
Copy link
Member Author

Unfortunately, the CI fails with:

      ) at retrieve.R#229
   6: if (renv_record_tagged(record))
        return(renv_retrieve_repos_impl(record)) at retrieve.R#577
   5: name <- name %||% renv_retrieve_repos_archive_name(record, type) at retrieve.R#899
   4: name <- name %||% renv_retrieve_repos_archive_name(record, type) at retrieve.R#899
   3: ext <- renv_package_ext(type) at retrieve.R#712
   2: type <- match.arg(type, c("binary", "source")) at package.R#123
   1: stop(sprintf(ngettext(length(chs <- unique(choices[nzchar(choices)])), 
          "'arg' should be %s", "'arg' should be one of %s"), paste(dQuote(chs), 
  Execution halted
          collapse = ", ")), domain = NA)

on macOS and on Ubuntu with:

- Installing terra ...                          FAILED

Error in dyn.load(file, DLLpath = DLLpath, ...) : 
  unable to load shared object '/home/runner/work/rpops/rpops/renv/staging/1/terra/libs/terra.so':
  libproj.so.22: cannot open shared object file: No such file or directory
Calls: loadNamespace -> library.dynam -> dyn.load
Execution halted

Error: Error: error testing if 'terra' can be loaded [error code 1]
Traceback (most recent calls last):
14: renv::restore()
13: renv_restore_run_actions(project, diff, current, lockfile, rebuild)
12: renv_install_impl(records)
11: renv_install_staged(records)
10: renv_install_default(records)
 9: handler(package, renv_install_package(record))
 8: renv_install_package(record)
 7: withCallingHandlers(renv_install_package_impl(record), error = function(e) writef("FAILED"))
 6: renv_install_package_impl(record)
 5: withCallingHandlers(if (isbin) renv_install_test(package), error = function(err) unlink(installpath, 
        recursive = TRUE))
 4: renv_install_test(package)
 3: renv_system_exec(command = R(), args = c("--vanilla", "-s", "-f", 
        renv_shell_path(script)), action = sprintf("testing if '%s' can be loaded", 
        package))
 2: abort(sprintf("error %s [error code %i]", action, status), body = renv_system_exec_details(command, 
        args, output))
 1: stop(fallback)
Execution halted

For numerical results, however, I don't expect any issues because the changes are supposed to preserve status quo and only formalize the conversions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant