-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: implement Silent Payments sending #284
base: master
Are you sure you want to change the base?
Backend: implement Silent Payments sending #284
Conversation
14f35fe
to
9d3c534
Compare
With regards to the first commit message, I've noticed a pattern in the way you write them, when the commit does more than 1 thing. Let's say commit does A and B and C. You usually do this:
Please stop using that style! If the commit contains more than one change, then do this:
Or, if you prefer a prose style, then you have to link each thing A, B, C between them. For example:
So please when listing things, either use bullets, or link each thing with conjunctions (especially if you can explain in which way A is related to B, how B is related to C or A, etc). |
Updated NBitcoin to version 7.0.13 because older NBitcoin versions can't decode bech32 strings of length > 90, which is needed for Silent Payment address decoding. Since UnknowParameters property of BitcoinUrlBuilder is deprecated in new version, use UnknownParameters instead. As return type of new property is different, had to change some code.
Implemented sending of Silent Payments (BIP-352). Created tests for Silent Payments based on test data for BIP-352.
20a65c2
to
e06f0eb
Compare
Refactoring: addressed comments to the PR.
e798eb1
to
1587b2e
Compare
Implemented sending of Silent Payments (BIP-352).
Created tests for Silent Payments based on test data for BIP-352.
Updated NBitcoin to version 7.0.13 because older NBitcoin
versions can't decode bech32 strings of length > 90, which is
needed for Silent Payment address decoding. Since
UnknowParameters property of BitcoinUrlBuilder is deprecated
in new version, use UnknownParameters instead. As return type
of new property is different, had to change some code.