Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK build with dotnet6+xbuild #220

Merged
merged 12 commits into from
Oct 13, 2023
Merged

Commits on Aug 28, 2023

  1. build: remove Nuget.Restore.targets

    This was kzu's project[1] which had a very interesting goal:
    make nuget restore be part of the build process itself (kind of
    like a PreBuild target so that your IDE did the restore before
    building, regardless if the IDE had nuget support or not).
    
    Now, there's several reasons to remove it (ordered by level of
    importance):
    
    1. We're moving soon to dotnet v6 and newer, where a restore is
    always assumed by the IDEs and command-line builds (the command
    is even called "dotnet restore" itself, no need to specify
    "nuget" anymore, as the term 'restore' has become part of the
    dotnet jargon already).
    
    2. Looking back, I introduced it in 2017 [2] but I kinda regret
    doing it because of all the hacks (such as needing to generate
    the special file 'before.$solutionFileName.targets before the
    build) required to make it work, the ugliness of its code (not
    really blaming the author here, maybe MSBuild's XML syntax is
    generally unreadable), and:
    
    3. The fact that despite the use of it, there were certain
    sccenarios that needed an explicit restore of other solutions
    or projects to make the build work with Xamarin.Forms.
    
    So as there were explicit restores happening in make.fsx
    anyway, let's make nuget restore explicitly handled now in all
    cases by make.fsx (this quirk will not live very long anyway,
    just as long as the Xamarin.Forms frontend lives, which is
    getting replaced by MAUI soon).
    
    This commit also disables nuget restore parallel processing
    to prevent flaky nuget restore on mono.
    
    [1] https://github.com/kzu/Nuget.Restore
    [2] 9804b65
    knocte authored and aarani committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c5095e0 View commit details
    Browse the repository at this point in the history
  2. Rename main solution from gwallet to geewallet

    We renamed the project long time ago so it is about
    time to follow suit with the solution file name.
    knocte authored and aarani committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d504f73 View commit details
    Browse the repository at this point in the history
  3. Move non-main solutions to src/ subdir

    This way they don't get confused with the main solution
    (and still can be used by make.fsx to build with the command
    line).
    knocte authored and aarani committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    03db5e5 View commit details
    Browse the repository at this point in the history
  4. *.sln: update

    Updating links to scripts and Fsdk in main solution, and
    deleting them on the others (since the others will only be used
    for building now, not for using in the IDE).
    knocte authored and aarani committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a671a9c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Frontend.XF.GTK: add DLL refs for project refs

    This allows for building Backend and Frontend.XF with
    separate build engine like .NET 6.
    aarani committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c8c59c2 View commit details
    Browse the repository at this point in the history
  2. scripts: using legacy & non-legacy tools together

    This commit allows for using legacy and non-legacy build
    tools together to build GTK frontend without using MS's
    binaries (newmono-msbuild).
    
    It works by building .NETStandard project (that xbuild can't
    build) using .NET6 and building GTK project using xbuild.
    
    Co-authored-by: Afshin Arani <[email protected]>
    knocte and aarani committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7f6c88d View commit details
    Browse the repository at this point in the history
  3. scripts,GitHubCI: remove curl as a dependency

    Now that we removed [1] NuGet.Restore.targets, and NuGet.exe
    gets downloaded by Fsdk via WebClient, I don't think we need
    curl anymore.
    
    [1] 04277ed
    knocte authored and aarani committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    14c46b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. CI: add more deps to stockdotnet6-stockmono lane

    This commit alongside [1] allow for building GTK front-
    end on this lane.
    
    [1] 7f6c88d
    aarani committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    8ee7f26 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acab2ad View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. scripts/make: build XF frontend when dotnet exists

    Before this commit, we were assuming that legacy tools
    were not present if dotnet was present. Now, if dotnet
    is present, and legacy tools also are (so that the XF
    frontend can be built), then make will build the frontend.
    
    Obj path in some projects had to be changed like it was
    done in [1] because building same project once with dotnet
    and once with MSBuild causes problems (it happens in macOS
    when both mono and dotnet exist).
    
    [1] 6b3c64e
    aarani authored and knocte committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    06efc5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e02b82 View commit details
    Browse the repository at this point in the history
  3. Introduce .git-blame-ignore-revs

    There have been some recent cosmetic commits so it's better to
    group them here to avoid git-blame pollution.
    knocte committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4d00028 View commit details
    Browse the repository at this point in the history