Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: pin FSharp.Core in JsonRpcSharp #216

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

aarani
Copy link
Contributor

@aarani aarani commented Jul 31, 2023

This commit updates the JsonRpcSharp library which
uses an older version of FSharp.Core.

This fixes the FSharp.Core version conflict
problem caused by [1] which was trying to fix
integration tests in [2].

[1]
3bcde0b
[2]
9392215

@knocte
Copy link
Member

knocte commented Jul 31, 2023

Missing the why.

@knocte
Copy link
Member

knocte commented Jul 31, 2023

This fixes the problem caused by

What problem???

Also, if you don't use references like this [1], then commitlint is going to complain

This commit updates the JsonRpcSharp library which
uses an older version of FSharp.Core.

This fixes the FSharp.Core version conflict
problem caused by [1] which was trying to fix
integration tests in [2].

[1]
nblockchain@3bcde0b
[2]
nblockchain@9392215
@knocte knocte merged commit 3d8ef50 into nblockchain:stable Aug 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants