Skip to content

Commit

Permalink
scripts/snap_build.sh: clean before building
Browse files Browse the repository at this point in the history
There's an issue with snap package generation after last merge,
but CI was failing with the wrong error message:

```
System.ArgumentException: Target directory already exists: /home/runner/work/geewallet/geewallet/staging/lib/geewallet
Parameter name: targetDir
  at FSI_0005.Fsdk.Misc.CopyDirectoryRecursively (System.IO.DirectoryInfo sourceDir, System.IO.DirectoryInfo targetDir,
```

This is because the snap package job is retried several times
(as per [1]), so we should clean up first before trying to
build, so that retries work.

[1] 30a7678
  • Loading branch information
knocte committed Aug 25, 2023
1 parent e3f929d commit 73da7c4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions scripts/snap_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ set -euxo pipefail
# but as we're not using the 'make' plugin, we need to this manually now
DEBIAN_FRONTEND=noninteractive sudo apt install -y fsharp build-essential pkg-config cli-common-dev mono-devel libgtk2.0-cil-dev

# just in case this is a retry-run, we want to clean artifacts from previous try
rm -rf ./staging

./configure.sh --prefix=./staging
make
make install
Expand Down

0 comments on commit 73da7c4

Please sign in to comment.