ci: update github ci action #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @techytushar, thanks for the submission! Would you mind adding Python version 3.10 and Nautobot version 1.4 to the matrix as well? |
techytushar
force-pushed
the
update-ci#63
branch
from
79d34b2 to
7503442
Compare
|
@joewesch Done ✅ |
joewesch
reviewed
Oct 24, 2022
.github/workflows/ci.yml
Outdated
| - python-version: "3.9" | ||
| nautobot-version: "1.3" | ||
| python-version: ["3.7", "3.8", "3.9", "3.10"] | ||
| nautobot-version: ["1.2", "1.3", "1.4"] |
There was a problem hiding this comment.
Looks like we need to exclude a combination that doesn't exist.
Suggested change
| nautobot-version: ["1.2", "1.3", "1.4"] | |
| nautobot-version: ["1.2", "1.3", "1.4"] | |
| exclude: | |
| - python-version: 3.10 | |
| nautobot-version: 1.2 |
|
@joewesch any thoughts on the failure within the tests? Do we just need to re-run it? |
|
The |
techytushar
force-pushed
the
update-ci#63
branch
from
7503442 to
c6a15ac
Compare
|
Now it's getting hit with the same bug as #79. @techytushar, sorry but can you remove Nautobot 1.4 from the tests for now. We will need to override the nautobot_config.py file if we want that version to run. |
Signed-off-by: Tushar Mittal <[email protected]>
techytushar
force-pushed
the
update-ci#63
branch
from
c6a15ac to
80f0672
Compare
joewesch
approved these changes
Nov 2, 2022
|
Thanks @techytushar & @joewesch !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Mittal [email protected]
Fixes: #63