Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for py3.12 #36

Merged
merged 29 commits into from
Aug 23, 2024
Merged

Add support for py3.12 #36

merged 29 commits into from
Aug 23, 2024

Conversation

gsnider2195
Copy link
Contributor

@gsnider2195 gsnider2195 commented Aug 13, 2024 •
edited
Loading

gsnider2195
gsnider2195 commented Aug 14, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@gsnider2195 gsnider2195 requested a review from smk4664 August 14, 2024 20:25
smk4664
smk4664 reviewed Aug 19, 2024
View reviewed changes
tasks.py Outdated Show resolved Hide resolved
smk4664
smk4664 previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but left a comment.

snaselj
snaselj previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@snaselj snaselj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmsirbu
cmsirbu reviewed Aug 20, 2024
View reviewed changes
development/Dockerfile Outdated Show resolved Hide resolved
cmsirbu
cmsirbu reviewed Aug 20, 2024
View reviewed changes
invoke.example.yml Outdated Show resolved Hide resolved
@gsnider2195 gsnider2195 dismissed stale reviews from snaselj and smk4664 via 720c045 August 20, 2024 15:13
@gsnider2195 gsnider2195 requested review from cmsirbu and smk4664 August 20, 2024 15:16
@gsnider2195 gsnider2195 mentioned this pull request Aug 21, 2024
Closed
@gsnider2195 gsnider2195 reopened this Aug 21, 2024
smk4664
smk4664 reviewed Aug 21, 2024
View reviewed changes
development/Dockerfile Outdated Show resolved Hide resolved
@gsnider2195
Copy link
Contributor Author

gsnider2195 commented Aug 22, 2024 •
edited
Loading

I think this is ready to merge now. I moved all of the new CI logic into tasks.py so it's easier to replicate locally. TODO tomorrow: Still need to test it against golden-config again and a couple other apps with lots of dependencies.

cmsirbu
cmsirbu reviewed Aug 22, 2024
View reviewed changes
invoke.example.yml Outdated Show resolved Hide resolved
@gsnider2195 gsnider2195 mentioned this pull request Aug 22, 2024
Closed
smk4664
smk4664 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates!

cmsirbu
cmsirbu approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsnider2195 gsnider2195 merged commit ec80893 into develop Aug 23, 2024
14 of 15 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-python3.12 branch August 23, 2024 17:02
@gsnider2195 gsnider2195 mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks itdependsnetworks left review comments

@glennmatthews glennmatthews glennmatthews left review comments

@bryanculver bryanculver bryanculver left review comments

@smk4664 smk4664 smk4664 approved these changes

@cmsirbu cmsirbu cmsirbu approved these changes

@snaselj snaselj snaselj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gsnider2195 @bryanculver @snaselj @glennmatthews @itdependsnetworks @cmsirbu @smk4664