Support modifying custom fields on vm interfaces #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lungj
requested review from
jvanderaa,
jmcgill298 and
joewesch
as code owners
lungj
force-pushed
the
feature-vm-interface-custom-fields
branch
from
355c832 to
8938ae6
Compare
joewesch
requested changes
Nov 2, 2023
lungj
force-pushed
the
feature-vm-interface-custom-fields
branch
from
8938ae6 to
931207a
Compare
|
@joewesch Thanks for the review! I think I've addressed your comments. |
joewesch
approved these changes
Nov 6, 2023
|
@lungj can you see if you're missing the latest changes from develop to get the tests to pass? |
lungj
force-pushed
the
feature-vm-interface-custom-fields
branch
from
931207a to
06defa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #75, but for virtual machine interfaces.