Allow Configuration of Subscription Channels #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to11mtm
force-pushed
the
allow-channel-configuration
branch
from
e49da81
to
0ba3142
Compare
to11mtm
commented
Jul 21, 2023
| { | ||
| var overrideOpts = subChannelOpts.Value; | ||
| return new BoundedChannelOptions(overrideOpts.Capacity ?? | ||
| DefaultChannelOptions.Capacity) |
There was a problem hiding this comment.
It seemed better from a maintenance perspective to fallback to DefaultChannelOptions rather than re-specify defaults for these. If preferred I can just re-specify defaults however.
src/NATS.Client.Core/NatsSub.cs
Outdated
| @@ -55,7 +55,7 @@ public abstract class NatsSubBase : INatsSub | |||
| _cts.Token.UnsafeRegister( | |||
| static (self, _) => | |||
| { | |||
| ((NatsSubBase) self!).EndSubscription(NatsSubEndReason.Cancelled); | |||
| ((NatsSubBase)self!).EndSubscription(NatsSubEndReason.Cancelled); | |||
There was a problem hiding this comment.
Linter complained about this so I went ahead and did it. If revert is preferred LMK.
There was a problem hiding this comment.
Make sure to run dotnet format. That should fix these issues as well.
| @@ -1,3 +1,5 @@ | |||
| using System.Threading.Channels; | |||
There was a problem hiding this comment.
I think this using came in because of the XmlDoc, if preferred I can just use full type name in xmldoc?
|
@to11mtm couls you rebase please? There are no conflicts but it'd be easier to see without warnings etc. which was fixed afterwards. |
to11mtm
force-pushed
the
allow-channel-configuration
branch
from
0ba3142
to
216583a
Compare
to11mtm
force-pushed
the
allow-channel-configuration
branch
from
216583a
to
33538dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is value in being able to configure the
BoundedChannelOptionsfor a given subscription (or series of subscriptions.)For example, in cases where it is preferred to discard older data on a subscription, or cases where only the most recent value is the one that is desired.
This PR also has the benefit, in the default case, we can just re-use our internal
BoundedChannelOptionsrather than passing a new one every time a new subscription is created (i.e. less memory allocation.)Note that for the sake of reuse, this marked
internal staticonNatsSubrather thanprivate static, since to have a separate static readonly onNatsSub<T>would both be unnecessary and would cause a new static to be allocated for every newTonNatsSub<T>.