Add (force) reconnect method #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @pzajaczkowski! will check it out soon. just a quick repo maintenance thing: may I ask you to sign your commits and force push please. feel free to squash your commits if easier. this is CNCF recommendation we're following. sorry forgot to mention before in the issue. |
pzajaczkowski
force-pushed
the
add-reconnect-method
branch
from
9446d22 to
383cb3b
Compare
mtmk
approved these changes
Dec 4, 2024
mtmk
added a commit
that referenced
this pull request
Dec 10, 2024
Merged
mtmk
added a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #479
ReconnectAsyncmethodReconnectAsyncmethodI decided to follow naming proposed in design issue.
Ps.
OnSocketAvailableAsync_ShouldBeInvokedOnReconnection()test inNatsConnectionTest.cssometimes passes sometimes fails, so maybe there is some race? I've also noticed that it uses defaultTransportType(Tcp) instead of one provided byNatsConnectionTestclass. It means same test runs 4 times if i understand correctly.