Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DateTimeOffset converter to handle UTC serialization #661

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add DateTimeOffset converter to handle UTC serialization #661

merged 1 commit into from
Oct 22, 2024

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented Oct 17, 2024

fixes #659

@mtmk mtmk linked an issue Oct 17, 2024 that may be closed by this pull request
Can't update a stream config on a cluster when using mirroring and an optional start time #659
Closed
@mtmk mtmk requested a review from scottf October 17, 2024 20:34
@darkwatchuk
Copy link
Contributor

Thank you.

MauriceVanVeen
MauriceVanVeen approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit fbc8a67 into main Oct 22, 2024
13 checks passed
@mtmk mtmk deleted the 659-fix-update-stream-date-time branch October 22, 2024 10:02
mtmk added a commit that referenced this pull request Oct 22, 2024
@mtmk
Release 2.5.2
b97d542 
* Add DateTimeOffset converter to handle UTC serialization (#661)
@mtmk mtmk mentioned this pull request Oct 22, 2024
Merged
mtmk added a commit that referenced this pull request Oct 22, 2024
@mtmk
Release 2.5.2 (#663)
3462ebf 
* Add DateTimeOffset converter to handle UTC serialization (#661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

@scottf scottf Awaiting requested review from scottf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't update a stream config on a cluster when using mirroring and an optional start time
3 participants
@mtmk @darkwatchuk @MauriceVanVeen