NatsSub simplification and JetStream support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove INatsSubBuilder interfaces: This is to reduce unnecessary complexity since NatsSubBase can be used as the contract in SubscriptionManager * Create a separation of public interfaces and internal handling for subscriptions by using INatsSub* interfaces for public methods and using NatsSubBase as the internal handling interface with internals exposed such as Pending messages. * Push responsibility of reconnections to SubscriptionManager so that not only we can renew subscriptions but in the case of JetStream consumers recovery, we can issue pull requests for example.
|
Looks good, I like this approach! Want to clean up the commented sections so we can merge it? |
Brilliant! I shall clean it up. |
mtmk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove INatsSubBuilder interfaces: This is to reduce unnecessary complexity since NatsSubBase can be used as the contract in SubscriptionManager
Create a separation of public interfaces and internal handling for subscriptions by using INatsSub* interfaces for public methods and using NatsSubBase as the internal handling interface with internals exposed such as Pending messages.
Push responsibility of reconnections to SubscriptionManager so that not only we can renew subscriptions but in the case of JetStream consumers recovery, we can issue pull requests for example.