JetStream consumer options #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added header parsing with codes. * Subscription exception to be thrown on dispose
caleblloyd
reviewed
Aug 7, 2023
|
We seem to have an issue with |
caleblloyd
reviewed
Aug 9, 2023
Comment on lines
78
to
82
| _userMessageChannel = Channel.CreateBounded<NatsJSMsg<T?>>(new BoundedChannelOptions(1_000) | ||
| { | ||
| FullMode = BoundedChannelFullMode.Wait, | ||
| AllowSynchronousContinuations = false, | ||
| }); |
There was a problem hiding this comment.
should this take the options from NatsSubOpts.ChannelOptions?
There was a problem hiding this comment.
True 💯 I didn't think of that.
Comment on lines
87
to
91
| _notificationChannel = Channel.CreateBounded<NatsJSNotification>(new BoundedChannelOptions(1_000) | ||
| { | ||
| FullMode = BoundedChannelFullMode.DropOldest, | ||
| AllowSynchronousContinuations = false, | ||
| }); |
There was a problem hiding this comment.
1k seems excessive but I don't really know what a good number would be - 10? 100? 😆
Also doesn't really seem worth making configurable. I guess they are small so 1k might be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement JetStream Consumer API
consume()options based on ADR-37.The design idea is to implement a
NatsJSSubBaseclass to handle control messages and timeouts. Then we can implement specific classes for all three calls,next(),fetch()andconsume(). In this PR onlyconsume()is implemented.