Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: raise status message when doing incorrect pull #1195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: raise status message when doing incorrect pull #1195

wants to merge 1 commit into from

Conversation

MauriceVanVeen
Copy link
Member

Resolves #1194

Simple potential fix is enabling raiseStatusWarnings in the _pull(..).

Would keep the behaviour the same, just informing the user of the status message being hit:

Aug 09, 2024 12:07:58 PM io.nats.client.impl.ErrorListenerLoggerImpl pullStatusWarning
WARNING: pullStatusWarning, Connection: 13, Subscription: 631365415, Consumer Name: 8V2ygPms7b, Status:Status{code=409, message='Exceeded MaxRequestBatch of 1'}

@MauriceVanVeen MauriceVanVeen requested a review from scottf August 9, 2024 10:17
scottf
scottf requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottf scottf scottf requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When maxBatch, maxBytes, maxExpires are exceeded there is only a timeout but no status message
2 participants
@MauriceVanVeen @scottf