Move CI to github actions #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Apr 22, 2024
| - name: "Go: 1.22.x (nats-server@main)" | ||
| go: "1.22.x" | ||
| before_script: | ||
| - go get -modfile go_test.mod github.com/nats-io/nats-server/v2@main |
There was a problem hiding this comment.
I guess testing this one could be using a different cron outside of testing too?
There was a problem hiding this comment.
Yes I think having it set up as a separate workflow with cron will be necessary since there is no allow-failures option in github actions, only continue-on-error which still makes the PR red. I'll do that.
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
github-actions
branch
4 times, most recently
from
4412580
to
d2da2f5
Compare
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
github-actions
branch
from
d2da2f5
to
47225c1
Compare
Signed-off-by: Piotr Piotrowski <[email protected]>
|
I would add description in PR why we are leaving travis config for now and what are the next steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports CI from travis to github actions.
This PR does not remove
.travis.ymlin order to verify that after merging to main the 2 CIs work similarly and the latest-server workflow triggers as expected. Travis configuration will be removed in a follow-up PR, together with switching the badge source inREADME.Signed-off-by: Piotr Piotrowski [email protected]