Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service pkg and deprecate micro pkg #1466

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add service pkg and deprecate micro pkg #1466

wants to merge 3 commits into from

Conversation

bruth
Copy link
Member

@bruth bruth commented Nov 10, 2023

Summary of changes:

  • New service package
  • Type aliases and wrapped functions retained in micro package including a test to confirm
  • Add service.New in favor of service.AddService to remove naming stutter

The micro package type aliases everything from the service package
for backwards compatibility, but is now deprecated.

The micro/test package is there to assert the micro-imported tests
work as expected.

Signed-off-by: Byron Ruth <[email protected]>
service.AddService is now deprecated.

Signed-off-by: Byron Ruth <[email protected]>
Signed-off-by: Byron Ruth <[email protected]>
@bruth
Copy link
Member Author

bruth commented Nov 10, 2023

Test failures so far are unrelated to this change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant