-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHANGED] More verbose endpoint info on INFO requests #1277
Conversation
Signed-off-by: Piotr Piotrowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
EDIT: I just realized that we need to recompile and deploy all our existing microservices to make that actually work. |
@oderwat sorry for your trouble, so you're saying that the change works for you now? If not let me know, we'll be working on that! |
@piotrpio this stuff works like a charm. I totally forgot that we needed to recompile the services and was puzzled for some minutes :) P.S.: There is still the problem with #1307 (comment) and I can't find a reason for that. |
@piotrpio That is fine. I was just using the nighttime for trying some of the new stuff. The new API has time. The changes to micro were more important to me because we are having some parts of our system released in beta some days ago, and I am nervous and want to use the monitoring and continue writing and testing of the deployment daemon, which is based on the discovery through metadata. |
Nats CLI should have latest schemas in main. |
Addresses nats-io/nats-architecture-and-design#220