Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.11] Update goreleaser to build .tar.gz for linux, .zip for windows #6365

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

alexbozhenko
Copy link
Contributor

There is no point in building .tar.gz. for windows and .zip for linux.

When .tar.gz. was added in #1589
goreleaser did not have a feature to override the archive.
Now it does(found it in https://github.com/golangci/golangci-lint/blob/master/.golangci.yml)

Test plan:

# goreleaser release --snapshot --clean -f .goreleaser.yml
# find dist/ -name '*.zip' -or -name '*.tar.gz' | sort
dist/nats-server-v2.11.0-dev-darwin-amd64.tar.gz
dist/nats-server-v2.11.0-dev-darwin-arm64.tar.gz
dist/nats-server-v2.11.0-dev-freebsd-amd64.tar.gz
dist/nats-server-v2.11.0-dev-linux-386.tar.gz
dist/nats-server-v2.11.0-dev-linux-amd64.tar.gz
dist/nats-server-v2.11.0-dev-linux-arm64.tar.gz
dist/nats-server-v2.11.0-dev-linux-arm6.tar.gz
dist/nats-server-v2.11.0-dev-linux-arm7.tar.gz
dist/nats-server-v2.11.0-dev-linux-mips64le.tar.gz
dist/nats-server-v2.11.0-dev-linux-ppc64le.tar.gz
dist/nats-server-v2.11.0-dev-linux-s390x.tar.gz
dist/nats-server-v2.11.0-dev-windows-386.zip
dist/nats-server-v2.11.0-dev-windows-amd64.zip
dist/nats-server-v2.11.0-dev-windows-arm64.zip
dist/nats-server-v2.11.0-dev-windows-arm6.zip
dist/nats-server-v2.11.0-dev-windows-arm7.zip

Signed-off-by: Alex Bozhenko [email protected]

@alexbozhenko alexbozhenko requested a review from a team as a code owner January 10, 2025 22:07
@alexbozhenko alexbozhenko changed the title Use .tar.gz for linux, .zip for windows upd goreleaser to build .tar.gz for linux, .zip for windows Jan 10, 2025
@derekcollison derekcollison requested a review from wallyqs January 10, 2025 22:27
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is a chance that folks depend on this but v2.11 would be a good cut-off point.

@wallyqs wallyqs changed the title upd goreleaser to build .tar.gz for linux, .zip for windows [v2.11] Update goreleaser to build .tar.gz for linux, .zip for windows Jan 22, 2025
@derekcollison derekcollison merged commit e54cc94 into nats-io:main Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants