Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] LeafNode: queue interest on leaf not propagated with permissions on hub #6291

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

kozlovic
Copy link
Member

If the hub has a user with subscribe permissions on a literal subject that the leaf is trying to create a queue subscription on, the interest may not be propagated.

The issue was caused by the fact that we were checking the permissions on the key (that includes subject and queue name) instead of the subject itself.

Resolves #6281

Signed-off-by: Ivan Kozlovic [email protected]

…ons on hub

If the hub has a user with subscribe permissions on a literal subject
that the leaf is trying to create a queue subscription on, the interest
may not be propagated.

The issue was caused by the fact that we were checking the permissions
on the key (that includes subject and queue name) instead of the subject
itself.

Resolves #6281

Signed-off-by: Ivan Kozlovic <[email protected]>
@kozlovic kozlovic requested a review from a team as a code owner December 20, 2024 19:54
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 87e32fe into main Dec 20, 2024
5 checks passed
@derekcollison derekcollison deleted the fix_6281 branch December 20, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaf node interest propagation filtering with queue groups - Exact subject not matching
2 participants