Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filestore: Disambiguate hbit usage with new cbit flag #6287

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

neilalexander
Copy link
Member

@neilalexander neilalexander commented Dec 20, 2024

The hbit had two purposes depending on whether it was applied to the mb.cache.idx or the rl but it could be confusing. This PR adds a new cbit for clarity, although it has the same computed value.

Signed-off-by: Neil Twigg [email protected]

The `hbit` had two purposes depending on whether it was applied to the
`mb.cache.idx` or the `rl` but it could be confusing.

Signed-off-by: Neil Twigg <[email protected]>
@neilalexander neilalexander requested a review from a team as a code owner December 20, 2024 16:15
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit e1ff049 into main Dec 20, 2024
5 checks passed
@derekcollison derekcollison deleted the neil/cbit branch December 20, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants