-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for placement tags and preferred
to metaleader stepdown request
#6282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/jsstepdownpreferred
branch
from
December 19, 2024 11:07
3887950
to
f607366
Compare
neilalexander
changed the title
Add
Add support for placement tags and Dec 19, 2024
preferred_server
to metaleader stepdown requestpreferred_server
to metaleader stepdown request
neilalexander
force-pushed
the
neil/jsstepdownpreferred
branch
from
December 19, 2024 12:06
3ce0de6
to
63bc8d5
Compare
neilalexander
force-pushed
the
neil/jsstepdownpreferred
branch
from
December 19, 2024 14:06
63bc8d5
to
d67ca4f
Compare
neilalexander
force-pushed
the
neil/jsstepdownpreferred
branch
from
December 19, 2024 16:45
8d60838
to
8bec6b1
Compare
This makes it possible to nominate a JetStream metaleader transfer to a specific server or servers that match a specific set of tags. Also factors out some of the logic for making the preferred leader decision so that it could be reused for stream & consumer stepdowns. Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/jsstepdownpreferred
branch
from
December 19, 2024 16:45
8bec6b1
to
da0cbf7
Compare
neilalexander
changed the title
Add support for placement tags and
Add support for placement tags and Dec 19, 2024
preferred_server
to metaleader stepdown requestpreferred
to metaleader stepdown request
derekcollison
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
derekcollison
added a commit
that referenced
this pull request
Dec 19, 2024
… stepdown requests (#6284) Like #6282, this adds preferred placement support to stream and consumer stepdowns too. Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to nominate a JetStream metaleader transfer to servers matching specific placement tags in addition to cluster names, or optionally, to a specific named server.
preferred_server
is specified then placement will select that server only.cluster
ortags
can be supplied for placement. If both thecluster
andtags
are supplied then the placement will select a server that matches both.tags
are specified, the placement will select servers only if they match all supplied tags.Also factors out some of the logic for making the preferred leader decision so that it could be reused for stream & consumer stepdowns.
Signed-off-by: Neil Twigg [email protected]