Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-flake setup of mem WQ restart test #6278

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

MauriceVanVeen
Copy link
Member

TestNoRaceJetStreamClusterMemoryWorkQueueLastSequenceResetAfterRestart sometimes fails with a nats: timeout, but that's only in the setup code. That setup code is made to run in parallel to have the test run a lot faster, but it can sometimes result in timeouts on CI.

Allow for some retries in that section since it's only for setup. And if the setup fails the asserts after will not be able to work anyway.

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 18, 2024 09:16
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit e5ccb2d into main Dec 18, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/de-flake-mem-wq-restart branch December 18, 2024 14:07
wallyqs added a commit that referenced this pull request Jan 9, 2025
#### Dependencies
- #6323
- #6324

####  Leafnode
- #6291

#### JetStream
- #6226
- #6235
- #6277
- #6279
- #6283
- #6289
- #6316
- #6317
- #6325
- #6326
- #6335
- #6338
- #6341
- #6344
- #6150
- #6351
- #6355

#### Tests
- #6278
- #6297
- #6300
- #6343
- #6329
- #6330
- #6331
- #6332
- #6334
- #6356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants