NRG: Use configured sync intervals for group stores #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If the server is set to sync always, do the same for the Raft log. | ||
| js.srv.optsMu.RLock() | ||
| syncAlways := js.srv.opts.SyncAlways | ||
| syncInterval := js.srv.opts.SyncInterval |
There was a problem hiding this comment.
Does this match 5 mins? Noticed this was slightly more delayed then default 2m.
There was a problem hiding this comment.
They will now match the default 2 minutes. There's nothing in the git history that explains why it was 5 minutes.
There was a problem hiding this comment.
We probably would like to not have them firing at the same time.
Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/nrgsyncinterval
branch
from
ae8397c
to
4f9abd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neil Twigg [email protected]