Reduce allocations in consumers #6039
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise a lot of allocations escape to the heap due to the `json.Unmarshal()`. Signed-off-by: Neil Twigg <[email protected]>
Signed-off-by: Neil Twigg <[email protected]>
Signed-off-by: Neil Twigg <[email protected]>
kozlovic
reviewed
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes that should reduce allocations in consumers:
JSApiConsumerGetNextRequeststructs are now pooled, as they were unavoidably escaping to the heap;waitingRequeststructs are now returned to the pool correctly if hittingMaxWaiting;hdrbuffer from pooledjsPubMsgwhen returning consumer errors to the client.Signed-off-by: Neil Twigg [email protected]