Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] enable scoped users to have templates that are not limited to a subject token #5981

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Oct 9, 2024

Relaxed template logic to allow a template in a scoped user to be in line with the subject, enabling uses like KV_{{tag(foo)}}. This allows more flexibility for some arcane cases even if the tag requirement is that it will still be lower-cased.

Signed-off-by: Alberto Ricart [email protected]

Signed-off-by: Alberto Ricart <[email protected]>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison
Copy link
Member

Need to fix this..

image

@ripienaar
Copy link
Contributor

nice, I'd be interested in exporting processUserPermissionsTemplate to provide a UI in nats auth that can show ACLs expanded during JWT info expanded just as the server would

@aricart
Copy link
Member Author

aricart commented Oct 10, 2024

nice, I'd be interested in exporting processUserPermissionsTemplate to provide a UI in nats auth that can show ACLs expanded during JWT info expanded just as the server would

I got that and better: https://github.com/aricart/aclgenerator

Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
@derekcollison derekcollison merged commit 378bad6 into main Oct 10, 2024
5 checks passed
@derekcollison derekcollison deleted the relax-templates branch October 10, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants